Review Request 128312: Fix notify by taskbar

Martin Tobias Holmedahl Sandsmark martin.sandsmark at kde.org
Tue Jun 28 21:52:45 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128312/
-----------------------------------------------------------

Review request for KDE Frameworks and Martin Klapetek.


Repository: knotifications


Description
-------

For whatever reasons, the current implementation of notify by taskbar doesn't work locally. It also isn't implemented at all on e. g. OS X.

QApplication has a proper replacement that works on all platforms, so this simply switches to using that, and re-enables the notifybytaskbar on OS X.


Diffs
-----

  src/knotificationmanager.cpp 6f790b5 
  src/notifybytaskbar.cpp 036d20a 

Diff: https://git.reviewboard.kde.org/r/128312/diff/


Testing
-------

Noticed notifications in the taskbar where there earlier were none.


Thanks,

Martin Tobias Holmedahl Sandsmark

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160628/045de518/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list