Review Request 128312: Fix notify by taskbar

[Martin Tobias Holmedahl Sandsmark]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128312/
-----------------------------------------------------------

(Updated June 30, 2016, 8:20 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Martin Klapetek.


Changes
-------

Submitted with commit 2bcbc09e29a4e87790033ec399bcd83685e73505 by Martin T. H. Sandsmark to branch master.


Repository: knotifications


Description
-------

For whatever reasons, the current implementation of notify by taskbar doesn't work locally. It also isn't implemented at all on e. g. OS X.

QApplication has a proper replacement that works on all platforms, so this simply switches to using that, and re-enables the notifybytaskbar on OS X.


Diffs
-----

  src/knotificationmanager.cpp 6f790b5 
  src/notifybytaskbar.cpp 036d20a 

Diff: https://git.reviewboard.kde.org/r/128312/diff/


Testing
-------

Noticed notifications in the taskbar where there earlier were none.


Thanks,

Martin Tobias Holmedahl Sandsmark

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160630/139faa45/attachment.html>