Review Request 128249: Add switch to disable KParts' handling of window titles

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128249/#review96832
-----------------------------------------------------------



You should also add a note in the KParts::Part::setWindowCaption signal to mention that it has no effect if the KParts MainWindow deactivated the handling of window titles -- so part authors are not too surprised ;)


src/mainwindow.h (line 89)
<https://git.reviewboard.kde.org/r/128249/#comment65419>

    befor => before



src/mainwindow.h (line 91)
<https://git.reviewboard.kde.org/r/128249/#comment65420>

    boolen => boolean



src/mainwindow.h (line 92)
<https://git.reviewboard.kde.org/r/128249/#comment65418>

    Missing @since 5.24


- David Faure


On June 23, 2016, 7:05 p.m., Andreas Cord-Landwehr wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128249/
> -----------------------------------------------------------
> 
> (Updated June 23, 2016, 7:05 p.m.)
> 
> 
> Review request for KDE Frameworks, David Faure and Kevin Funk.
> 
> 
> Repository: kparts
> 
> 
> Description
> -------
> 
> Applications that use several KParts, like KDevelop, want to do the
> window title settings themselves. To enable that without causing a
> flickering of the KParts' title and the application's title, an
> explicit switch is required, since simply removing the setWindowTitle
> connection after executing a KParts::MainWindow::createGUI(...) call still
> causes an initial flickering, when the GUIActivateEvent is sent in
> the createGUI method. Sending such an event should stay in the createGUI
> method, though.
> 
> 
> Diffs
> -----
> 
>   src/mainwindow.h 61a92e3 
>   src/mainwindow.cpp be0b7dd 
> 
> Diff: https://git.reviewboard.kde.org/r/128249/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andreas Cord-Landwehr
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160624/e0b0121c/attachment-0001.html>