Review Request 128249: Add switch to disable KParts' handling of window titles
Andreas Cord-Landwehr
cordlandwehr at kde.org
Fri Jun 24 16:14:52 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128249/
-----------------------------------------------------------
(Updated Juni 24, 2016, 4:14 nachm.)
Review request for KDE Frameworks, David Faure and Kevin Funk.
Changes
-------
thanks for the documentation proof reading, should be correct English now
Repository: kparts
Description
-------
Applications that use several KParts, like KDevelop, want to do the
window title settings themselves. To enable that without causing a
flickering of the KParts' title and the application's title, an
explicit switch is required, since simply removing the setWindowTitle
connection after executing a KParts::MainWindow::createGUI(...) call still
causes an initial flickering, when the GUIActivateEvent is sent in
the createGUI method. Sending such an event should stay in the createGUI
method, though.
Diffs (updated)
-----
src/mainwindow.h 61a92e3
src/mainwindow.cpp be0b7dd
src/part.h 29791d5
Diff: https://git.reviewboard.kde.org/r/128249/diff/
Testing
-------
Thanks,
Andreas Cord-Landwehr
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160624/28ad01d0/attachment.html>
More information about the Kde-frameworks-devel
mailing list