Review Request 128084: Handle reading /proc/cpuinfo for Arm processors

[Lamarque Souza]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128084/#review96240
-----------------------------------------------------------




src/solid/devices/backends/udev/cpuinfo.cpp (line 70)
<https://git.reviewboard.kde.org/r/128084/#comment65041>

    This extracts the current cpu speed, not the maximum. Is that what you want? Yes then I think you should rename extractCpuSpeed() to extractCurrentCpuSpeed().


- Lamarque Souza


On June 3, 2016, 12:15 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128084/
> -----------------------------------------------------------
> 
> (Updated June 3, 2016, 12:15 p.m.)
> 
> 
> Review request for KDE Frameworks and Solid.
> 
> 
> Repository: solid
> 
> 
> Description
> -------
> 
> The /proc/cpuinfo format is wildly different between architectures, our
> current method for scraping data only works on x86.
> 
> This patch moves all parsing logic into cpuinfo.cpp and adds a fallback
> search that works for arm and arm64 architectures.
> 
> ----
> https://github.com/torvalds/linux/blob/master/arch/x86/kernel/cpu/proc.c#L55
> 
> https://github.com/torvalds/linux/blob/master/arch/arm64/kernel/cpuinfo.c#L104
> 
> 
> Diffs
> -----
> 
>   src/solid/devices/backends/udev/cpuinfo.h e8d5dda729535e767b4640f41a01f4d0e27e6542 
>   src/solid/devices/backends/udev/cpuinfo.cpp ecaad58ceee34d46343b67015c03d9a3de87ee72 
>   src/solid/devices/backends/udev/udevdevice.cpp 9fb5e092679cd3c6860b2055cf3dedb915addfda 
>   src/solid/devices/backends/udev/udevprocessor.cpp 80d14f5b40b4478a32d7c113747fe9da50e54b6f 
> 
> Diff: https://git.reviewboard.kde.org/r/128084/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160606/e0a421d9/attachment.html>