Review Request 128084: Handle reading /proc/cpuinfo for Arm processors
David Edmundson
david at davidedmundson.co.uk
Thu Jun 9 13:40:31 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128084/
-----------------------------------------------------------
(Updated June 9, 2016, 1:40 p.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Frameworks and Solid.
Changes
-------
Submitted with commit 9870418bf299e3c6aede79c81c13cd07bba8e6e7 by David Edmundson to branch master.
Repository: solid
Description
-------
The /proc/cpuinfo format is wildly different between architectures, our
current method for scraping data only works on x86.
This patch moves all parsing logic into cpuinfo.cpp and adds a fallback
search that works for arm and arm64 architectures.
----
https://github.com/torvalds/linux/blob/master/arch/x86/kernel/cpu/proc.c#L55
https://github.com/torvalds/linux/blob/master/arch/arm64/kernel/cpuinfo.c#L104
Diffs
-----
src/solid/devices/backends/udev/cpuinfo.h e8d5dda729535e767b4640f41a01f4d0e27e6542
src/solid/devices/backends/udev/cpuinfo.cpp ecaad58ceee34d46343b67015c03d9a3de87ee72
src/solid/devices/backends/udev/udevdevice.cpp 9fb5e092679cd3c6860b2055cf3dedb915addfda
src/solid/devices/backends/udev/udevprocessor.cpp 80d14f5b40b4478a32d7c113747fe9da50e54b6f
Diff: https://git.reviewboard.kde.org/r/128084/diff/
Testing
-------
Thanks,
David Edmundson
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160609/3efa3053/attachment.html>
More information about the Kde-frameworks-devel
mailing list