<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128084/">https://git.reviewboard.kde.org/r/128084/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/128084/diff/1/?file=467508#file467508line70" style="color: black; font-weight: bold; text-decoration: underline;">src/solid/devices/backends/udev/cpuinfo.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">70</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">int</span> <span class="n">speed</span> <span class="o">=</span> <span class="n">info</span><span class="p">.</span><span class="n">extractCpuInfoLine</span><span class="p">(</span><span class="n">processorNumber</span><span class="p">,</span> <span class="s">"cpu MHz</span><span class="se">\\</span><span class="s">s+:</span><span class="se">\\</span><span class="s">s+(</span><span class="se">\\</span><span class="s">d+).*"</span><span class="p">).</span><span class="n">toInt</span><span class="p">();</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This extracts the current cpu speed, not the maximum. Is that what you want? Yes then I think you should rename extractCpuSpeed() to extractCurrentCpuSpeed().</p></pre>
</div>
</div>
<br />
<p>- Lamarque Souza</p>
<br />
<p>On June 3rd, 2016, 12:15 p.m. UTC, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and Solid.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated June 3, 2016, 12:15 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
solid
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The /proc/cpuinfo format is wildly different between architectures, our
current method for scraping data only works on x86.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch moves all parsing logic into cpuinfo.cpp and adds a fallback
search that works for arm and arm64 architectures.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">----
https://github.com/torvalds/linux/blob/master/arch/x86/kernel/cpu/proc.c#L55</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">https://github.com/torvalds/linux/blob/master/arch/arm64/kernel/cpuinfo.c#L104</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/solid/devices/backends/udev/cpuinfo.h <span style="color: grey">(e8d5dda729535e767b4640f41a01f4d0e27e6542)</span></li>
<li>src/solid/devices/backends/udev/cpuinfo.cpp <span style="color: grey">(ecaad58ceee34d46343b67015c03d9a3de87ee72)</span></li>
<li>src/solid/devices/backends/udev/udevdevice.cpp <span style="color: grey">(9fb5e092679cd3c6860b2055cf3dedb915addfda)</span></li>
<li>src/solid/devices/backends/udev/udevprocessor.cpp <span style="color: grey">(80d14f5b40b4478a32d7c113747fe9da50e54b6f)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128084/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>