Review Request 128548: [kwidgetsaddons/autotests] Make sure we have a valid icon

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128548/#review97903
-----------------------------------------------------------


Ship it!




But wouldn't it be simpler to just always pass QIcon(somePixmap) in this test? It's not like it -needs- an icon from a theme.

- David Faure


On July 29, 2016, 11:46 a.m., Christoph Feck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128548/
> -----------------------------------------------------------
> 
> (Updated July 29, 2016, 11:46 a.m.)
> 
> 
> Review request for KDE Frameworks, David Faure and Scarlett Clark.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> -------
> 
> The kdualaction autotest fails, when the icon was not found in the current theme.
> 
> The reason is that KGuiItem returns a newly created Null QIcon() when passing any Null icon to setIcon().
> 
> Use a fallback icon instead.
> 
> 
> Diffs
> -----
> 
>   autotests/kdualactiontest.cpp 6b16c89 
> 
> Diff: https://git.reviewboard.kde.org/r/128548/diff/
> 
> 
> Testing
> -------
> 
> Passes with all eight combinations of:
> - "kde" icon present/not present
> - platform integration present/not present
> - Qt 5.6.1 tag/Qt 5.7 branch
> 
> 
> Thanks,
> 
> Christoph Feck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160729/be52cc7d/attachment.html>