Review Request 128548: [kwidgetsaddons/autotests] Make sure we have a valid icon
Christoph Feck
cfeck at kde.org
Fri Jul 29 11:46:44 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128548/
-----------------------------------------------------------
Review request for KDE Frameworks, David Faure and Scarlett Clark.
Repository: kwidgetsaddons
Description
-------
The kdualaction autotest fails, when the icon was not found in the current theme.
The reason is that KGuiItem returns a newly created Null QIcon() when passing any Null icon to setIcon().
Use a fallback icon instead.
Diffs
-----
autotests/kdualactiontest.cpp 6b16c89
Diff: https://git.reviewboard.kde.org/r/128548/diff/
Testing
-------
Passes with all eight combinations of:
- "kde" icon present/not present
- platform integration present/not present
- Qt 5.6.1 tag/Qt 5.7 branch
Thanks,
Christoph Feck
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160729/571b413b/attachment.html>
More information about the Kde-frameworks-devel
mailing list