Review Request 128548: [kwidgetsaddons/autotests] Make sure we have a valid icon

[Christoph Feck]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128548/
-----------------------------------------------------------

(Updated July 31, 2016, 1:26 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks, David Faure and Scarlett Clark.


Changes
-------

Submitted with commit 7e391bbc904928f01572561482a7574ae990dce8 by Christoph Feck to branch master.


Repository: kwidgetsaddons


Description
-------

The kdualaction autotest fails, when the icon was not found in the current theme.

The reason is that KGuiItem returns a newly created Null QIcon() when passing any Null icon to setIcon().

Use a fallback icon instead.


Diffs
-----

  autotests/kdualactiontest.cpp 6b16c89 

Diff: https://git.reviewboard.kde.org/r/128548/diff/


Testing
-------

Passes with all eight combinations of:
- "kde" icon present/not present
- platform integration present/not present
- Qt 5.6.1 tag/Qt 5.7 branch


Thanks,

Christoph Feck

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160731/7aa069c0/attachment.html>