Review Request 127813: Reduce string modifications when calling translatePath
Aleix Pol Gonzalez
aleixpol at kde.org
Mon Jul 4 14:05:35 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127813/
-----------------------------------------------------------
(Updated July 4, 2016, 4:05 p.m.)
Review request for KDE Frameworks and Matthew Dawson.
Changes
-------
Address David's comment.
Repository: kconfig
Description
-------
Don't drop the file: prefix twice in every run.
Use appropriate API on paths rather than string handling, when possible.
Diffs (updated)
-----
src/core/kconfiggroup.cpp 39d2441
Diff: https://git.reviewboard.kde.org/r/127813/diff/
Testing
-------
Tests pass, apps work.
Thanks,
Aleix Pol Gonzalez
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160704/2e364689/attachment.html>
More information about the Kde-frameworks-devel
mailing list