Review Request 127813: Reduce string modifications when calling translatePath

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127813/#review97082
-----------------------------------------------------------




src/core/kconfiggroup.cpp (line 420)
<https://git.reviewboard.kde.org/r/127813/#comment65576>

    This kind of code was wrong before your change, and is still wrong.
    Chopping file: is NEVER right.
    
    Example:
      file:///home/dfaure/file%231
    should lead to path "/home/dfaure/file#1"
    
    The only way to do this correctly is to use QUrl::toLocalFile().


- David Faure


On July 4, 2016, 1:48 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127813/
> -----------------------------------------------------------
> 
> (Updated July 4, 2016, 1:48 p.m.)
> 
> 
> Review request for KDE Frameworks and Matthew Dawson.
> 
> 
> Repository: kconfig
> 
> 
> Description
> -------
> 
> Don't drop the file: prefix twice in every run.
> Use appropriate API on paths rather than string handling, when possible.
> 
> 
> Diffs
> -----
> 
>   src/core/kconfiggroup.cpp 39d2441 
> 
> Diff: https://git.reviewboard.kde.org/r/127813/diff/
> 
> 
> Testing
> -------
> 
> Tests pass, apps work.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160704/2146a005/attachment.html>