Review Request 127813: Reduce string modifications when calling translatePath

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127813/#review97083
-----------------------------------------------------------




src/core/kconfiggroup.cpp (line 426)
<https://git.reviewboard.kde.org/r/127813/#comment65578>

    this if() can now be removed, no?
    
    (which means we don't really need the actualPath variable)



src/core/kconfiggroup.cpp (line 427)
<https://git.reviewboard.kde.org/r/127813/#comment65577>

    please remove the misleading comment


- David Faure


On July 4, 2016, 2:05 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127813/
> -----------------------------------------------------------
> 
> (Updated July 4, 2016, 2:05 p.m.)
> 
> 
> Review request for KDE Frameworks and Matthew Dawson.
> 
> 
> Repository: kconfig
> 
> 
> Description
> -------
> 
> Don't drop the file: prefix twice in every run.
> Use appropriate API on paths rather than string handling, when possible.
> 
> 
> Diffs
> -----
> 
>   src/core/kconfiggroup.cpp 39d2441 
> 
> Diff: https://git.reviewboard.kde.org/r/127813/diff/
> 
> 
> Testing
> -------
> 
> Tests pass, apps work.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160704/c5ffa90f/attachment-0001.html>