Review Request 127813: Reduce string modifications when calling translatePath

Aleix Pol Gonzalez aleixpol at kde.org
Mon Jul 4 13:48:00 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127813/
-----------------------------------------------------------

(Updated July 4, 2016, 3:48 p.m.)


Review request for KDE Frameworks and Matthew Dawson.


Changes
-------

Remove the more controversial part of the patch.


Summary (updated)
-----------------

Reduce string modifications when calling translatePath


Repository: kconfig


Description (updated)
-------

Don't drop the file: prefix twice in every run.
Use appropriate API on paths rather than string handling, when possible.


Diffs (updated)
-----

  src/core/kconfiggroup.cpp 39d2441 

Diff: https://git.reviewboard.kde.org/r/127813/diff/


Testing
-------

Tests pass, apps work.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160704/2a4d9401/attachment.html>


More information about the Kde-frameworks-devel mailing list