Review Request 128233: Don't trust files claiming to be created on unix more than other files

[Sune Vuorela]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128233/
-----------------------------------------------------------

(Updated July 3, 2016, 1:03 p.m.)


Review request for KDE Frameworks and David Faure.


Changes
-------

Updated based on comments. 
    Assume a directory is a directory, even if the permission bit is set wrong
    
    For some historical reasons, we special case zip files claiming to be
    created on unix and trust the content a bit more.
    
    Zip files in the wild have shown to violate this, so don't trust them as much.
    
    Thanks to Jonathan Marten for the test case
    
    BUG: 364071


Repository: karchive


Description
-------

Don't trust files claiming to be created on unix more than other files
    
    For some historical reasons, we special case zip files claiming to be
    created on unix and trust the content regarding file rights a bit better.
    
    Zip files in the wild have shown to violate this, so don't trust them.
    
    Thanks to Jonathan Marten for the test case
    
    BUG: 364071


Diffs (updated)
-----

  autotests/data/unusual_but_valid_364071.zip PRE-CREATION 
  autotests/karchivetest.h 5a6375c 
  autotests/karchivetest.cpp dd03dac 
  src/kzip.cpp e7e8477 

Diff: https://git.reviewboard.kde.org/r/128233/diff/


Testing
-------


Thanks,

Sune Vuorela

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160703/e0b73029/attachment-0001.html>