<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128233/">https://git.reviewboard.kde.org/r/128233/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and David Faure.</div>
<div>By Sune Vuorela.</div>
<p style="color: grey;"><i>Updated July 3, 2016, 1:03 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Updated based on comments.
Assume a directory is a directory, even if the permission bit is set wrong
For some historical reasons, we special case zip files claiming to be
created on unix and trust the content a bit more.
Zip files in the wild have shown to violate this, so don't trust them as much.
Thanks to Jonathan Marten for the test case
BUG: 364071</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
karchive
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Don't trust files claiming to be created on unix more than other files</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">For some historical reasons, we special case zip files claiming to be
created on unix and trust the content regarding file rights a bit better.
Zip files in the wild have shown to violate this, so don't trust them.
Thanks to Jonathan Marten for the test case
BUG: 364071
</pre></div>
</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/data/unusual_but_valid_364071.zip <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/karchivetest.h <span style="color: grey">(5a6375c)</span></li>
<li>autotests/karchivetest.cpp <span style="color: grey">(dd03dac)</span></li>
<li>src/kzip.cpp <span style="color: grey">(e7e8477)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128233/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>