Review Request 128233: Don't trust files claiming to be created on unix more than other files

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128233/#review97067
-----------------------------------------------------------


Fix it, then Ship it!





autotests/karchivetest.cpp (line 1112)
<https://git.reviewboard.kde.org/r/128233/#comment65571>

    s/data/fileName/



autotests/karchivetest.cpp (line 1118)
<https://git.reviewboard.kde.org/r/128233/#comment65573>

    QString()



autotests/karchivetest.cpp (line 1119)
<https://git.reviewboard.kde.org/r/128233/#comment65572>

    join(' ')
    
    The fromUtf8() looks a bit overkill, it's all ascii ;)


- David Faure


On July 3, 2016, 1:03 p.m., Sune Vuorela wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128233/
> -----------------------------------------------------------
> 
> (Updated July 3, 2016, 1:03 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: karchive
> 
> 
> Description
> -------
> 
> Don't trust files claiming to be created on unix more than other files
>     
>     For some historical reasons, we special case zip files claiming to be
>     created on unix and trust the content regarding file rights a bit better.
>     
>     Zip files in the wild have shown to violate this, so don't trust them.
>     
>     Thanks to Jonathan Marten for the test case
>     
>     BUG: 364071
> 
> 
> Diffs
> -----
> 
>   autotests/data/unusual_but_valid_364071.zip PRE-CREATION 
>   autotests/karchivetest.h 5a6375c 
>   autotests/karchivetest.cpp dd03dac 
>   src/kzip.cpp e7e8477 
> 
> Diff: https://git.reviewboard.kde.org/r/128233/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sune Vuorela
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160703/1c6ae323/attachment.html>