Review Request 128349: Silence warning about widget already having a layout

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128349/#review97046
-----------------------------------------------------------


Ship it!




I agree with the fix, but not with the commit log :)

Setting a widget for a layout is fine for the main layout of a widget, just not for sublayouts.

- David Faure


On July 2, 2016, 9:43 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128349/
> -----------------------------------------------------------
> 
> (Updated July 2, 2016, 9:43 p.m.)
> 
> 
> Review request for KDE Frameworks and Martin Klapetek.
> 
> 
> Repository: knotifications
> 
> 
> Description
> -------
> 
> Setting the parent of a QLayout manually is usually wrong.
> 
> 
> Diffs
> -----
> 
>   src/kpassivepopup.cpp 4561eb9 
> 
> Diff: https://git.reviewboard.kde.org/r/128349/diff/
> 
> 
> Testing
> -------
> 
> «QLayout: Attempting to add QLayout "" to QWidget "", which already has a layout» does not appear anymore, but the passive popup does.
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160702/7ea7a4b8/attachment-0001.html>