Review Request 128349: Silence warning about widget already having a layout
Michael Pyne
mpyne at kde.org
Sat Jul 2 23:21:21 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128349/#review97045
-----------------------------------------------------------
Ship it!
Ship It!
- Michael Pyne
On July 2, 2016, 9:43 p.m., Martin Tobias Holmedahl Sandsmark wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128349/
> -----------------------------------------------------------
>
> (Updated July 2, 2016, 9:43 p.m.)
>
>
> Review request for KDE Frameworks and Martin Klapetek.
>
>
> Repository: knotifications
>
>
> Description
> -------
>
> Setting the parent of a QLayout manually is usually wrong.
>
>
> Diffs
> -----
>
> src/kpassivepopup.cpp 4561eb9
>
> Diff: https://git.reviewboard.kde.org/r/128349/diff/
>
>
> Testing
> -------
>
> «QLayout: Attempting to add QLayout "" to QWidget "", which already has a layout» does not appear anymore, but the passive popup does.
>
>
> Thanks,
>
> Martin Tobias Holmedahl Sandsmark
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160702/c3bc8214/attachment.html>
More information about the Kde-frameworks-devel
mailing list