Review Request 128349: Silence warning about widget already having a layout

Martin Tobias Holmedahl Sandsmark martin.sandsmark at kde.org
Sun Jul 3 13:57:22 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128349/
-----------------------------------------------------------

(Updated July 3, 2016, 4:57 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Martin Klapetek.


Changes
-------

Submitted with commit dd495133cbf0d99811632b7868047001f92a1528 by Martin T. H. Sandsmark to branch master.


Repository: knotifications


Description
-------

Setting the parent of a QLayout manually is usually wrong.


Diffs
-----

  src/kpassivepopup.cpp 4561eb9 

Diff: https://git.reviewboard.kde.org/r/128349/diff/


Testing
-------

«QLayout: Attempting to add QLayout "" to QWidget "", which already has a layout» does not appear anymore, but the passive popup does.


Thanks,

Martin Tobias Holmedahl Sandsmark

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160703/53971464/attachment.html>


More information about the Kde-frameworks-devel mailing list