Review Request 126934: Reduce use of gettext API.

[Chusslove Illich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126934/#review91826
-----------------------------------------------------------



I'm fine with this, I'm just thinking that the file as whole would look somewhat "disbalanced" if someone inspects it later. Could you maybe remove all uses of *cgettext API, so that the changes are symmetric for both dnpgettext* and dpgettext* functions/macros?

- Chusslove Illich


On Јан. 31, 2016, 9:53 пре п., Andreas Cord-Landwehr wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126934/
> -----------------------------------------------------------
> 
> (Updated Јан. 31, 2016, 9:53 пре п.)
> 
> 
> Review request for KDE Frameworks, Aleix Pol Gonzalez and Chusslove Illich.
> 
> 
> Repository: ki18n
> 
> 
> Description
> -------
> 
> This change removes usage of dcnpgettext and npgettext and by this
> allows building of ki18n against libintl-lite, which provides a
> viable libintl alternative on e.g. Android systems (which does not
> provide libintl). This change does not do any functional changes.
> The changed gettext.h header is only used internally.
> 
> 
> Diffs
> -----
> 
>   cmake/FindLibIntl.cmake 887dbc71354c856e7bf39147e5634bd39f09b326 
>   src/gettext.h 608f38aaf85d464b5314368d5af84948348823a8 
> 
> Diff: https://git.reviewboard.kde.org/r/126934/diff/
> 
> 
> Testing
> -------
> 
> Unit tests still pass.
> 
> 
> Thanks,
> 
> Andreas Cord-Landwehr
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160131/e341187a/attachment.html>