Review Request 126936: help: fix garbage sent when serving static files
Pino Toscano
pino at kde.org
Sun Jan 31 10:01:14 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126936/
-----------------------------------------------------------
Review request for KDE Frameworks, David Faure and Luigi Toscano.
Repository: kio
Description
-------
Switch from a `QByteArray` to a simplier stack-based char array, using the actual number of bytes read when sending the data using `data()` (reusing the memory from the array).
This removes the garbage sent when serving static files, i.e. those stored in directories and not as part of a `.cache.bz2` file.
Diffs
-----
src/ioslaves/help/kio_help.cpp 7b97599a250f113e25b9c6efe238afab08b3fe2c
Diff: https://git.reviewboard.kde.org/r/126936/diff/
Testing
-------
The data sent for static files now is the actual bytes of the files, without garbage at the end.
Thanks,
Pino Toscano
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160131/e11a09c1/attachment.html>
More information about the Kde-frameworks-devel
mailing list