<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126934/">https://git.reviewboard.kde.org/r/126934/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm fine with this, I'm just thinking that the file as whole would look somewhat "disbalanced" if someone inspects it later. Could you maybe remove all uses of *cgettext API, so that the changes are symmetric for both dnpgettext* and dpgettext* functions/macros?</pre>
<br />
<p>- Chusslove Illich</p>
<br />
<p>On јануар 31st, 2016, 9:53 пре п. CET, Andreas Cord-Landwehr wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks, Aleix Pol Gonzalez and Chusslove Illich.</div>
<div>By Andreas Cord-Landwehr.</div>
<p style="color: grey;"><i>Updated Јан. 31, 2016, 9:53 пре п.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ki18n
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This change removes usage of dcnpgettext and npgettext and by this
allows building of ki18n against libintl-lite, which provides a
viable libintl alternative on e.g. Android systems (which does not
provide libintl). This change does not do any functional changes.
The changed gettext.h header is only used internally.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Unit tests still pass.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>cmake/FindLibIntl.cmake <span style="color: grey">(887dbc71354c856e7bf39147e5634bd39f09b326)</span></li>
<li>src/gettext.h <span style="color: grey">(608f38aaf85d464b5314368d5af84948348823a8)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126934/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>