Review Request 126028: Add support for desktopFileName to NETWinInfo

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126028/#review90472
-----------------------------------------------------------

Ship it!


Sorry, forgot to review this earlier.

The @since version needs to be updated (to 5.19 actually, since I just tagged 5.18). Unless you shout quickly for a 5.18 respin.

- David Faure


On Nov. 11, 2015, 1:15 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126028/
> -----------------------------------------------------------
> 
> (Updated Nov. 11, 2015, 1:15 p.m.)
> 
> 
> Review request for KDE Frameworks, kwin and David Faure.
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> -------
> 
> Implementation for the new hint _NET_WM_DESKTOP_FILE, see [1].
> Till it's fully standardized going with a KDE prefix, so it's
> _KDE_NET_WM_DESKTOP_FILE. Once it's specified the atom name can
> be exchanged.
> 
> [1] https://mail.gnome.org/archives/wm-spec-list/2015-November/msg00000.html
> 
> 
> Diffs
> -----
> 
>   autotests/netwininfotestclient.cpp 59a3980ff589fc3de9e479905c191bcbf1747644 
>   src/netwm_def.h 0938e2b28f6b0d425a16748b52a5b8e4704d8af6 
>   src/platforms/xcb/atoms_p.h b5a6e7efc98ff8033c0854041428a7d4b52ffc93 
>   src/platforms/xcb/netwm.h 220340bf0e96d2a186b72e118b601471529aeabf 
>   src/platforms/xcb/netwm.cpp 2335c297bb627065ca9b7e691290bfbdc64bccc3 
>   src/platforms/xcb/netwm_p.h e0645bbfd2c2061d9201fe34160c6201d89f4a89 
> 
> Diff: https://git.reviewboard.kde.org/r/126028/diff/
> 
> 
> Testing
> -------
> 
> tested with a modified kcmshell5 and a modified desktop file.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160102/15e529db/attachment.html>