<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126028/">https://git.reviewboard.kde.org/r/126028/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Sorry, forgot to review this earlier.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The @since version needs to be updated (to 5.19 actually, since I just tagged 5.18). Unless you shout quickly for a 5.18 respin.</p></pre>
<br />
<p>- David Faure</p>
<br />
<p>On November 11th, 2015, 1:15 p.m. UTC, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks, kwin and David Faure.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Nov. 11, 2015, 1:15 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwindowsystem
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Implementation for the new hint _NET_WM_DESKTOP_FILE, see [1].
Till it's fully standardized going with a KDE prefix, so it's
_KDE_NET_WM_DESKTOP_FILE. Once it's specified the atom name can
be exchanged.
[1] https://mail.gnome.org/archives/wm-spec-list/2015-November/msg00000.html</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">tested with a modified kcmshell5 and a modified desktop file.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/netwininfotestclient.cpp <span style="color: grey">(59a3980ff589fc3de9e479905c191bcbf1747644)</span></li>
<li>src/netwm_def.h <span style="color: grey">(0938e2b28f6b0d425a16748b52a5b8e4704d8af6)</span></li>
<li>src/platforms/xcb/atoms_p.h <span style="color: grey">(b5a6e7efc98ff8033c0854041428a7d4b52ffc93)</span></li>
<li>src/platforms/xcb/netwm.h <span style="color: grey">(220340bf0e96d2a186b72e118b601471529aeabf)</span></li>
<li>src/platforms/xcb/netwm.cpp <span style="color: grey">(2335c297bb627065ca9b7e691290bfbdc64bccc3)</span></li>
<li>src/platforms/xcb/netwm_p.h <span style="color: grey">(e0645bbfd2c2061d9201fe34160c6201d89f4a89)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126028/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>