Review Request 126963: New class FavIconRequestJob in new lib KIOGui, for favicons retrieval.

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126963/
-----------------------------------------------------------

(Updated Feb. 2, 2016, 11:46 a.m.)


Review request for KDE Frameworks, Kevin Ottens, Laurent Montel, and Sune Vuorela.


Changes
-------

address laurent's comments (using QLatin1String for endsWith, since there's an overload for it)


Repository: kio


Description (updated)
-------

Replaces the favicons kded module from libkonq.

Looking up favicons from the cache no longer needs DBus, which makes
things considerably faster.

REVIEW: 126963

Change-Id: I9527b3d312117cbc3b3f854ffbdda07bafd782d7


Diffs (updated)
-----

  autotests/CMakeLists.txt 376b1ed48cbd4a285d096866a73c1928ce6c7766 
  autotests/favicontest.cpp PRE-CREATION 
  src/CMakeLists.txt 62e04a68648f0db738d38ebddf2578a65ff10c07 
  src/core/CMakeLists.txt 3343a6960cdce422a2cc1ca5253f7825bb0e0ada 
  src/core/faviconscache.cpp PRE-CREATION 
  src/core/faviconscache_p.h PRE-CREATION 
  src/core/global.h 5e8e8a086d406402a23b37d2d4835f970ad92753 
  src/core/global.cpp f5c20ec6f169e413836172616cd3d42ccc2d19eb 
  src/gui/CMakeLists.txt PRE-CREATION 
  src/gui/faviconrequestjob.h PRE-CREATION 
  src/gui/faviconrequestjob.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/126963/diff/


Testing
-------

Wrote a unittest, as complete as possible.

Didn't port any apps yet.


Thanks,

David Faure

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160202/feb95c56/attachment-0001.html>