Review Request 126963: New class FavIconRequestJob in new lib KIOGui, for favicons retrieval.

[Laurent Montel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126963/#review91922
-----------------------------------------------------------




autotests/CMakeLists.txt (line 50)
<https://git.reviewboard.kde.org/r/126963/#comment62726>

    indent here



autotests/favicontest.cpp (line 154)
<https://git.reviewboard.kde.org/r/126963/#comment62727>

    QStringLiteral()



autotests/favicontest.cpp (line 173)
<https://git.reviewboard.kde.org/r/126963/#comment62728>

    QStringLiteral(...)



src/core/faviconscache.cpp (line 66)
<https://git.reviewboard.kde.org/r/126963/#comment62729>

    QLatin1Char('/') etc.



src/gui/faviconrequestjob.h (line 78)
<https://git.reviewboard.kde.org/r/126963/#comment62730>

    Q_NULLPTR


- Laurent Montel


On fév. 2, 2016, 8:35 matin, David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126963/
> -----------------------------------------------------------
> 
> (Updated fév. 2, 2016, 8:35 matin)
> 
> 
> Review request for KDE Frameworks, Kevin Ottens, Laurent Montel, and Sune Vuorela.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> Replaces the favicons kded module from libkonq.
> 
> Looking up favicons from the cache no longer needs DBus, which makes
> things considerably faster.
> 
> Change-Id: I9527b3d312117cbc3b3f854ffbdda07bafd782d7
> 
> 
> Diffs
> -----
> 
>   autotests/CMakeLists.txt 376b1ed48cbd4a285d096866a73c1928ce6c7766 
>   autotests/favicontest.cpp PRE-CREATION 
>   src/CMakeLists.txt 62e04a68648f0db738d38ebddf2578a65ff10c07 
>   src/core/CMakeLists.txt 3343a6960cdce422a2cc1ca5253f7825bb0e0ada 
>   src/core/faviconscache.cpp PRE-CREATION 
>   src/core/faviconscache_p.h PRE-CREATION 
>   src/core/global.h 5e8e8a086d406402a23b37d2d4835f970ad92753 
>   src/core/global.cpp f5c20ec6f169e413836172616cd3d42ccc2d19eb 
>   src/gui/CMakeLists.txt PRE-CREATION 
>   src/gui/faviconrequestjob.h PRE-CREATION 
>   src/gui/faviconrequestjob.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126963/diff/
> 
> 
> Testing
> -------
> 
> Wrote a unittest, as complete as possible.
> 
> Didn't port any apps yet.
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160202/1233a27d/attachment.html>