<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126963/">https://git.reviewboard.kde.org/r/126963/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks, Kevin Ottens, Laurent Montel, and Sune Vuorela.</div>
<div>By David Faure.</div>
<p style="color: grey;"><i>Updated Feb. 2, 2016, 11:46 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">address laurent's comments (using QLatin1String for endsWith, since there's an overload for it)</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Replaces the favicons kded module from libkonq.
Looking up favicons from the cache no longer needs DBus, which makes
things considerably faster.
REVIEW: 126963
Change-Id: I9527b3d312117cbc3b3f854ffbdda07bafd782d7</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Wrote a unittest, as complete as possible.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Didn't port any apps yet.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/CMakeLists.txt <span style="color: grey">(376b1ed48cbd4a285d096866a73c1928ce6c7766)</span></li>
<li>autotests/favicontest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(62e04a68648f0db738d38ebddf2578a65ff10c07)</span></li>
<li>src/core/CMakeLists.txt <span style="color: grey">(3343a6960cdce422a2cc1ca5253f7825bb0e0ada)</span></li>
<li>src/core/faviconscache.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core/faviconscache_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core/global.h <span style="color: grey">(5e8e8a086d406402a23b37d2d4835f970ad92753)</span></li>
<li>src/core/global.cpp <span style="color: grey">(f5c20ec6f169e413836172616cd3d42ccc2d19eb)</span></li>
<li>src/gui/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/gui/faviconrequestjob.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/gui/faviconrequestjob.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126963/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>