Review Request 128629: Only require Xattr if the operating system is Linux

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128629/#review98444
-----------------------------------------------------------


Ship it!




Makes sense, i'll commit

- Albert Astals Cid


On Aug. 8, 2016, 10:16 p.m., Tobias Berner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128629/
> -----------------------------------------------------------
> 
> (Updated Aug. 8, 2016, 10:16 p.m.)
> 
> 
> Review request for KDE Frameworks, Johan Ouwerkerk and Vishesh Handa.
> 
> 
> Repository: kfilemetadata
> 
> 
> Description
> -------
> 
> In f399b699 Xattr was made a required dependency of `kfilemetadata`.
> 
> However `attr/xattr.h` is only included on Linux systems. The other operating
> systems are handled differently in `src/xattrp.h` -- so, only make it a
> required dependency if `CMAKE_SYSTEM_NAME matches Linux`.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 4cb67fc 
> 
> Diff: https://git.reviewboard.kde.org/r/128629/diff/
> 
> 
> Testing
> -------
> 
> Build-tested on FreeBSD
> 
> 
> Thanks,
> 
> Tobias Berner
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160817/93cf18f6/attachment.html>