Review Request 128629: Only require Xattr if the operating system is Linux

Tobias Berner tcberner at gmail.com
Mon Aug 8 10:05:23 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128629/
-----------------------------------------------------------

(Updated Aug. 8, 2016, 12:05 p.m.)


Review request for KDE Frameworks and Johan Ouwerkerk.


Repository: kfilemetadata


Description
-------

In f399b699 Xattr was made a required dependency of `kfilemetadata`.

However `attr/xattr.h` is only included on Linux systems. The other operating
systems are handled differently in `src/xattrp.h` -- so, only make it a
required dependency if `CMAKE_SYSTEM_NAME matches Linux`.


Diffs
-----

  CMakeLists.txt 4cb67fc 

Diff: https://git.reviewboard.kde.org/r/128629/diff/


Testing
-------

Build-tested on FreeBSD


Thanks,

Tobias Berner

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160808/87e1c1db/attachment.html>


More information about the Kde-frameworks-devel mailing list