Review Request 128629: Only require Xattr if the operating system is Linux
Tobias Berner
tcberner at gmail.com
Wed Aug 17 18:29:21 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128629/
-----------------------------------------------------------
(Updated Aug. 17, 2016, 6:29 p.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Frameworks, Johan Ouwerkerk and Vishesh Handa.
Changes
-------
Submitted with commit 163001ddac913ca565b52ec2fc96cd56e9ea31d4 by Albert Astals Cid on behalf of Tobias Berner to branch master.
Repository: kfilemetadata
Description
-------
In f399b699 Xattr was made a required dependency of `kfilemetadata`.
However `attr/xattr.h` is only included on Linux systems. The other operating
systems are handled differently in `src/xattrp.h` -- so, only make it a
required dependency if `CMAKE_SYSTEM_NAME matches Linux`.
Diffs
-----
CMakeLists.txt 4cb67fc
Diff: https://git.reviewboard.kde.org/r/128629/diff/
Testing
-------
Build-tested on FreeBSD
Thanks,
Tobias Berner
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160817/9b93aebc/attachment.html>
More information about the Kde-frameworks-devel
mailing list