Review Request 127777: Make KTipDialog use the domain of the application when translating the tips

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127777/
-----------------------------------------------------------

(Updated April 28, 2016, 10:43 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Chusslove Illich.


Changes
-------

Submitted with commit 2ffec51692eae1dad4db816dc462a23a11d0d169 by Albert Astals Cid to branch master.


Repository: kconfigwidgets


Description
-------

Makes no sense to use ::tr() here, we need to use i18n that is what the rest of the framework (and hence the app) uses.

The biggest question is if we want to allow passing a domain as parameter to showXTip in case someone has more esoteric use cases.


Diffs
-----

  src/ktipdialog.cpp e6a70af 

Diff: https://git.reviewboard.kde.org/r/127777/diff/


Testing
-------

kig tips now show translated.


Thanks,

Albert Astals Cid

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160428/9a7a87ee/attachment-0001.html>