Review Request 127777: Make KTipDialog use the domain of the application when translating the tips

[Chusslove Illich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127777/#review94931
-----------------------------------------------------------


Ship it!




I wouldn't add domain parameter to showXTip, until someone asks for it. To me KTipDialog looks like something that is really going to be used directly by applications, and if someone does find a reason to wrap it into another library, can also ask for adding the domain parameter.

- Chusslove Illich


On Април 28, 2016, 12:48 пре п., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127777/
> -----------------------------------------------------------
> 
> (Updated Април 28, 2016, 12:48 пре п.)
> 
> 
> Review request for KDE Frameworks and Chusslove Illich.
> 
> 
> Repository: kconfigwidgets
> 
> 
> Description
> -------
> 
> Makes no sense to use ::tr() here, we need to use i18n that is what the rest of the framework (and hence the app) uses.
> 
> The biggest question is if we want to allow passing a domain as parameter to showXTip in case someone has more esoteric use cases.
> 
> 
> Diffs
> -----
> 
>   src/ktipdialog.cpp e6a70af 
> 
> Diff: https://git.reviewboard.kde.org/r/127777/diff/
> 
> 
> Testing
> -------
> 
> kig tips now show translated.
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160427/ffd95048/attachment.html>