Review Request 127777: Make KTipDialog use the domain of the application when translating the tips
Albert Astals Cid
aacid at kde.org
Wed Apr 27 22:48:45 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127777/
-----------------------------------------------------------
Review request for KDE Frameworks and Chusslove Illich.
Repository: kconfigwidgets
Description
-------
Makes no sense to use ::tr() here, we need to use i18n that is what the rest of the framework (and hence the app) uses.
The biggest question is if we want to allow passing a domain as parameter to showXTip in case someone has more esoteric use cases.
Diffs
-----
src/ktipdialog.cpp e6a70af
Diff: https://git.reviewboard.kde.org/r/127777/diff/
Testing
-------
kig tips now show translated.
Thanks,
Albert Astals Cid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160427/2801b725/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list