Review Request 124856: Call newInstance from the child on first invocation

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124856/
-----------------------------------------------------------

(Updated Sept. 23, 2015, 7:44 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Thiago Macieira.


Changes
-------

Submitted with commit fd06026843e0cb965eaa58422b43469cd934dd85 by Albert Astals Cid to branch master.


Repository: kdelibs4support


Description
-------

For the first invocation, call newInstance ourselves instead of relying on the parent process to do it.

With the new threading patches in qt dbus the current code races as the parent may end up calling newInstance before the child has set up the object that handles it.


Diffs
-----

  src/kdeui/kuniqueapplication.cpp 713c6f4 
  src/kdeui/kuniqueapplication_p.h de4b328 

Diff: https://git.reviewboard.kde.org/r/124856/diff/


Testing
-------

konsole starts fine with this + Thiago's Qt dbus threading patches


Thanks,

Albert Astals Cid

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150923/c7f52f1a/attachment.html>