Review Request 124856: Call newInstance from the child on first invocation

[Thiago Macieira]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124856/#review85847
-----------------------------------------------------------


David: please note that the QtDBus changes made it in for 5.6, not 5.7. If you want to discuss suspending the execution of the thread, please start that discussion. I have the beginnings of a hackish patch for that...

- Thiago Macieira


On Set. 23, 2015, 7:44 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124856/
> -----------------------------------------------------------
> 
> (Updated Set. 23, 2015, 7:44 p.m.)
> 
> 
> Review request for KDE Frameworks and Thiago Macieira.
> 
> 
> Repository: kdelibs4support
> 
> 
> Description
> -------
> 
> For the first invocation, call newInstance ourselves instead of relying on the parent process to do it.
> 
> With the new threading patches in qt dbus the current code races as the parent may end up calling newInstance before the child has set up the object that handles it.
> 
> 
> Diffs
> -----
> 
>   src/kdeui/kuniqueapplication.cpp 713c6f4 
>   src/kdeui/kuniqueapplication_p.h de4b328 
> 
> Diff: https://git.reviewboard.kde.org/r/124856/diff/
> 
> 
> Testing
> -------
> 
> konsole starts fine with this + Thiago's Qt dbus threading patches
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150923/35c7da7b/attachment.html>