Review Request 124856: Call newInstance from the child on first invocation

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124856/#review85325
-----------------------------------------------------------


Personnally, I don't like very much the idea of modifying kdelibs4support code, and I consider that QtDBus should be behavior compatible with previous versions. But I won't veto this, if you want this in, go ahead, I'll know you'll handle any regressions.

- David Faure


On Aug. 21, 2015, 4:06 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124856/
> -----------------------------------------------------------
> 
> (Updated Aug. 21, 2015, 4:06 p.m.)
> 
> 
> Review request for KDE Frameworks and Thiago Macieira.
> 
> 
> Repository: kdelibs4support
> 
> 
> Description
> -------
> 
> For the first invocation, call newInstance ourselves instead of relying on the parent process to do it.
> 
> With the new threading patches in qt dbus the current code races as the parent may end up calling newInstance before the child has set up the object that handles it.
> 
> 
> Diffs
> -----
> 
>   src/kdeui/kuniqueapplication.cpp 713c6f4 
>   src/kdeui/kuniqueapplication_p.h de4b328 
> 
> Diff: https://git.reviewboard.kde.org/r/124856/diff/
> 
> 
> Testing
> -------
> 
> konsole starts fine with this + Thiago's Qt dbus threading patches
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150913/549fc22a/attachment.html>