Review Request 125271: KSycoca: rebuild ksycoca in process rather than executing kbuildsycoca5

David Faure faure at kde.org
Thu Sep 17 06:37:38 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125271/
-----------------------------------------------------------

(Updated Sept. 17, 2015, 6:37 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks, Albert Astals Cid and Boudewijn Rempt.


Changes
-------

Submitted with commit 87e346092d7d50b25ef930bbdb2effe6d9a103e4 by David Faure to branch master.


Repository: kservice


Description
-------

This is indeed a bit faster.
kmimeassociationstest went from 11-12s to 10.5-11s
and ksycocathreadtest from 11-12s to 7-8s.

REVIEW: 125271


Diffs
-----

  src/sycoca/kbuildsycoca.cpp 3685211e9da68f14516ec2b3d9a7e6b4f559b6f3 
  src/sycoca/kbuildsycoca_p.h c24413398694de29a788dd9498435572f5f605a3 
  src/sycoca/ksycoca.cpp c5465a828da615e87220304e3f8b160d471edbc7 

Diff: https://git.reviewboard.kde.org/r/125271/diff/


Testing
-------

ctest .


Thanks,

David Faure

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150917/e0705121/attachment.html>


More information about the Kde-frameworks-devel mailing list