Review Request 125271: KSycoca: rebuild ksycoca in process rather than executing kbuildsycoca5

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125271/#review85525
-----------------------------------------------------------

Ship it!


Ship It!

- Albert Astals Cid


On set. 16, 2015, 10:19 p.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125271/
> -----------------------------------------------------------
> 
> (Updated set. 16, 2015, 10:19 p.m.)
> 
> 
> Review request for KDE Frameworks, Albert Astals Cid and Boudewijn Rempt.
> 
> 
> Repository: kservice
> 
> 
> Description
> -------
> 
> This is indeed a bit faster.
> kmimeassociationstest went from 11-12s to 10.5-11s
> and ksycocathreadtest from 11-12s to 7-8s.
> 
> REVIEW: 125271
> 
> 
> Diffs
> -----
> 
>   src/sycoca/kbuildsycoca.cpp 3685211e9da68f14516ec2b3d9a7e6b4f559b6f3 
>   src/sycoca/kbuildsycoca_p.h c24413398694de29a788dd9498435572f5f605a3 
>   src/sycoca/ksycoca.cpp c5465a828da615e87220304e3f8b160d471edbc7 
> 
> Diff: https://git.reviewboard.kde.org/r/125271/diff/
> 
> 
> Testing
> -------
> 
> ctest .
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150916/ef5e1a37/attachment.html>