Review Request 125271: KSycoca: rebuild ksycoca in process rather than executing kbuildsycoca5

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125271/
-----------------------------------------------------------

(Updated Sept. 16, 2015, 10:19 p.m.)


Review request for KDE Frameworks, Albert Astals Cid and Boudewijn Rempt.


Changes
-------

Fix return value of recreate() when there is nothing to be done because another process took care of it. This isn't an error, so it should return true (this is why I actually documented the ret val of the function, I just forgot to adjust it afterwards). Caught by KSycocaThreadTest in one of the runs.


Repository: kservice


Description (updated)
-------

This is indeed a bit faster.
kmimeassociationstest went from 11-12s to 10.5-11s
and ksycocathreadtest from 11-12s to 7-8s.

REVIEW: 125271


Diffs (updated)
-----

  src/sycoca/kbuildsycoca.cpp 3685211e9da68f14516ec2b3d9a7e6b4f559b6f3 
  src/sycoca/kbuildsycoca_p.h c24413398694de29a788dd9498435572f5f605a3 
  src/sycoca/ksycoca.cpp c5465a828da615e87220304e3f8b160d471edbc7 

Diff: https://git.reviewboard.kde.org/r/125271/diff/


Testing
-------

ctest .


Thanks,

David Faure

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150916/b08b030d/attachment.html>