Review Request 125106: Minor optimizations

[Albert Astals Cid]

> On set. 8, 2015, 4:46 p.m., Milian Wolff wrote:
> > src/kconf_update/kconf_update.cpp, line 523
> > <https://git.reviewboard.kde.org/r/125106/diff/1/?file=402276#file402276line523>
> >
> >     QLatin1String

This was already a QLatin1String :D


> On set. 8, 2015, 4:46 p.m., Milian Wolff wrote:
> > src/kconf_update/kconf_update.cpp, line 250
> > <https://git.reviewboard.kde.org/r/125106/diff/1/?file=402276#file402276line250>
> >
> >     QLatin1String

Seems like a bug in clazy, sometimes it knows that it should use QLatin1String but it seems it didn't in this case.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125106/#review85019
-----------------------------------------------------------


On set. 8, 2015, 4:17 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125106/
> -----------------------------------------------------------
> 
> (Updated set. 8, 2015, 4:17 p.m.)
> 
> 
> Review request for KDE Frameworks and Matthew Dawson.
> 
> 
> Repository: kconfig
> 
> 
> Description
> -------
> 
> Ran the clazy tool (http://www.kdab.com/use-static-analysis-improve-performance/)
> 
> Mostly QStringLiteral/QLatin1String additions
> A few const & additions to non public methods
> 
> 
> Diffs
> -----
> 
>   src/core/kauthorized.cpp 4280524 
>   src/core/kconfig.cpp 4be9e6d 
>   src/core/kconfigbackend.cpp 67bdefa 
>   src/core/kconfigini.cpp 856b7b7 
>   src/core/kcoreconfigskeleton_p.h d098ef6 
>   src/core/kdesktopfile.cpp 49f37c3 
>   src/core/ksharedconfig.cpp e059b87 
>   src/gui/kwindowconfig.cpp a32c6cc 
>   src/kconf_update/kconf_update.cpp a1c98cb 
>   src/kconfig_compiler/kconfig_compiler.cpp 5c515f4 
> 
> Diff: https://git.reviewboard.kde.org/r/125106/diff/
> 
> 
> Testing
> -------
> 
> Compiles, test pass
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150908/576d3458/attachment-0001.html>