Review Request 125106: Minor optimizations

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125106/#review85019
-----------------------------------------------------------


in general +1, but I think some occassions should use QLatin1String in favor of QStringLiteral. Sergio, is your tool always suggesting QStringLiteral?


src/core/kauthorized.cpp (line 57)
<https://git.reviewboard.kde.org/r/125106/#comment58799>

    should be QLatin1String



src/kconf_update/kconf_update.cpp (line 250)
<https://git.reviewboard.kde.org/r/125106/#comment58800>

    QLatin1String



src/kconf_update/kconf_update.cpp (line 257)
<https://git.reviewboard.kde.org/r/125106/#comment58801>

    QLatin1String



src/kconf_update/kconf_update.cpp (line 263)
<https://git.reviewboard.kde.org/r/125106/#comment58802>

    QLatin1String



src/kconf_update/kconf_update.cpp (line 334)
<https://git.reviewboard.kde.org/r/125106/#comment58803>

    QLatin1String



src/kconf_update/kconf_update.cpp (line 523)
<https://git.reviewboard.kde.org/r/125106/#comment58804>

    QLatin1String



src/kconfig_compiler/kconfig_compiler.cpp (line 506)
<https://git.reviewboard.kde.org/r/125106/#comment58805>

    ost of the concatenations below should also use QLatin1String.
    
    are we enabling QStringBuilder for this repo btw?


- Milian Wolff


On Sept. 8, 2015, 4:17 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125106/
> -----------------------------------------------------------
> 
> (Updated Sept. 8, 2015, 4:17 p.m.)
> 
> 
> Review request for KDE Frameworks and Matthew Dawson.
> 
> 
> Repository: kconfig
> 
> 
> Description
> -------
> 
> Ran the clazy tool (http://www.kdab.com/use-static-analysis-improve-performance/)
> 
> Mostly QStringLiteral/QLatin1String additions
> A few const & additions to non public methods
> 
> 
> Diffs
> -----
> 
>   src/core/kauthorized.cpp 4280524 
>   src/core/kconfig.cpp 4be9e6d 
>   src/core/kconfigbackend.cpp 67bdefa 
>   src/core/kconfigini.cpp 856b7b7 
>   src/core/kcoreconfigskeleton_p.h d098ef6 
>   src/core/kdesktopfile.cpp 49f37c3 
>   src/core/ksharedconfig.cpp e059b87 
>   src/gui/kwindowconfig.cpp a32c6cc 
>   src/kconf_update/kconf_update.cpp a1c98cb 
>   src/kconfig_compiler/kconfig_compiler.cpp 5c515f4 
> 
> Diff: https://git.reviewboard.kde.org/r/125106/diff/
> 
> 
> Testing
> -------
> 
> Compiles, test pass
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150908/ddb24196/attachment-0001.html>