Review Request 125106: Minor optimizations

Albert Astals Cid aacid at kde.org
Fri Sep 11 23:56:10 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125106/
-----------------------------------------------------------

(Updated set. 11, 2015, 11:56 p.m.)


Review request for KDE Frameworks and Matthew Dawson.


Changes
-------

New run with clazy that suggests QLatin1String in some more occassions.

Yes, we have the string builder enabled.


Repository: kconfig


Description
-------

Ran the clazy tool (http://www.kdab.com/use-static-analysis-improve-performance/)

Mostly QStringLiteral/QLatin1String additions
A few const & additions to non public methods


Diffs (updated)
-----

  src/kconfig_compiler/kconfig_compiler.cpp 5c515f4 
  src/kconf_update/kconfigutils.cpp 0fec63a 
  src/kconf_update/kconf_update.cpp a1c98cb 
  src/gui/kwindowconfig.cpp a32c6cc 
  src/core/kdesktopfile.cpp 49f37c3 
  src/core/ksharedconfig.cpp e059b87 
  src/core/kconfigini.cpp 856b7b7 
  src/core/kcoreconfigskeleton_p.h d098ef6 
  src/core/kauthorized.cpp 4280524 
  src/core/kconfig.cpp 4be9e6d 
  src/core/kconfigbackend.cpp 67bdefa 

Diff: https://git.reviewboard.kde.org/r/125106/diff/


Testing
-------

Compiles, test pass


Thanks,

Albert Astals Cid

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150911/926eaa40/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list