Review Request 125779: properly handle middle click in navigatormenu

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125779/#review87352
-----------------------------------------------------------


Thanks for the patch!


src/filewidgets/kurlnavigatorbutton.cpp (lines 450 - 453)
<https://git.reviewboard.kde.org/r/125779/#comment59985>

    The coding style requests braces around one-lines if-else too.
    
    Also, I think this can do just
    
    emit clicked(btn);
    
    ...no need for the if at all (just like you did below)
    
    And I would suggest to use "button" instead of "btn", no reason to use abbrs.


- Martin Klapetek


On Oct. 24, 2015, 8:50 p.m., Ilia Kats wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125779/
> -----------------------------------------------------------
> 
> (Updated Oct. 24, 2015, 8:50 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> previously, two clicked() events were emitted upon middle click, one with Qt::MidButton and one with Qt::LeftButton, resulting in e.g. Dolphin both opening a new tab as well as changing the location of the current tab. This fixes that
> 
> 
> Diffs
> -----
> 
>   src/filewidgets/kurlnavigatorbutton.cpp e6aafb7 
>   src/filewidgets/kurlnavigatorbutton_p.h dbb3e7b 
>   src/filewidgets/kurlnavigatormenu.cpp d492c7c 
>   src/filewidgets/kurlnavigatormenu_p.h 70133d1 
> 
> Diff: https://git.reviewboard.kde.org/r/125779/diff/
> 
> 
> Testing
> -------
> 
> Opened Dolphin, tried left/right/middle click on the menu -> behaves as expected.
> 
> 
> Thanks,
> 
> Ilia Kats
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151024/f2b0f157/attachment-0001.html>