Review Request 125779: properly handle middle click in navigatormenu

Ilia Kats ilia-kats at gmx.net
Sat Oct 24 18:50:02 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125779/
-----------------------------------------------------------

Review request for KDE Frameworks.


Repository: kio


Description
-------

previously, two clicked() events were emitted upon middle click, one with Qt::MidButton and one with Qt::LeftButton, resulting in e.g. Dolphin both opening a new tab as well as changing the location of the current tab. This fixes that


Diffs
-----

  src/filewidgets/kurlnavigatorbutton.cpp e6aafb7 
  src/filewidgets/kurlnavigatorbutton_p.h dbb3e7b 
  src/filewidgets/kurlnavigatormenu.cpp d492c7c 
  src/filewidgets/kurlnavigatormenu_p.h 70133d1 

Diff: https://git.reviewboard.kde.org/r/125779/diff/


Testing
-------

Opened Dolphin, tried left/right/middle click on the menu -> behaves as expected.


Thanks,

Ilia Kats

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151024/d48004c2/attachment.html>


More information about the Kde-frameworks-devel mailing list