Review Request 125779: properly handle middle click in navigatormenu
Ilia Kats
ilia-kats at gmx.net
Sun Oct 25 08:23:58 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125779/
-----------------------------------------------------------
(Updated Oct. 25, 2015, 8:23 a.m.)
Review request for KDE Frameworks.
Changes
-------
minor fixes as suggested by Martin
Repository: kio
Description
-------
previously, two clicked() events were emitted upon middle click, one with Qt::MidButton and one with Qt::LeftButton, resulting in e.g. Dolphin both opening a new tab as well as changing the location of the current tab. This fixes that
Diffs (updated)
-----
src/filewidgets/kurlnavigatorbutton.cpp e6aafb7
src/filewidgets/kurlnavigatorbutton_p.h dbb3e7b
src/filewidgets/kurlnavigatormenu.cpp d492c7c
src/filewidgets/kurlnavigatormenu_p.h 70133d1
Diff: https://git.reviewboard.kde.org/r/125779/diff/
Testing
-------
Opened Dolphin, tried left/right/middle click on the menu -> behaves as expected.
Thanks,
Ilia Kats
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151025/922bbadf/attachment.html>
More information about the Kde-frameworks-devel
mailing list