Review Request 125924: KJob::kill(Quiet) should also exit the event loop
David Faure
faure at kde.org
Tue Nov 3 17:09:11 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125924/#review87944
-----------------------------------------------------------
Ship it!
Ship It!
- David Faure
On Nov. 2, 2015, 7:31 p.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125924/
> -----------------------------------------------------------
>
> (Updated Nov. 2, 2015, 7:31 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kcoreaddons
>
>
> Description
> -------
>
> To that end, this patch unifies both duplicated codes so it keeps consistent.
>
>
> Diffs
> -----
>
> src/lib/jobs/kjob.h cfb6909
> src/lib/jobs/kjob.cpp ff5a171
>
> Diff: https://git.reviewboard.kde.org/r/125924/diff/
>
>
> Testing
> -------
>
> Tests still pass, addresses issue in KIO: https://git.reviewboard.kde.org/r/125164/
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151103/56207285/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list