Review Request 125924: KJob::kill(Quiet) should also exit the event loop

Aleix Pol Gonzalez aleixpol at kde.org
Tue Nov 3 22:44:41 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125924/
-----------------------------------------------------------

(Updated Nov. 3, 2015, 10:44 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
-------

Submitted with commit 17a1ff06f234de4e763494101254542ff49a8659 by Aleix Pol to branch master.


Repository: kcoreaddons


Description
-------

To that end, this patch unifies both duplicated codes so it keeps consistent.


Diffs
-----

  src/lib/jobs/kjob.h cfb6909 
  src/lib/jobs/kjob.cpp ff5a171 

Diff: https://git.reviewboard.kde.org/r/125924/diff/


Testing
-------

Tests still pass, addresses issue in KIO: https://git.reviewboard.kde.org/r/125164/


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151103/7d6695d2/attachment.html>


More information about the Kde-frameworks-devel mailing list