Review Request 125924: KJob::kill(Quiet) should also exit the event loop

[Aleix Pol Gonzalez]

> On Nov. 3, 2015, 1:40 p.m., Milian Wolff wrote:
> > src/lib/jobs/kjob.h, line 644
> > <https://git.reviewboard.kde.org/r/125924/diff/1/?file=414449#file414449line644>
> >
> >     move this into KJobPrivate, no?

I don't think I can. I tried and I wasn't able to call the QPrivateSignal from there.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125924/#review87922
-----------------------------------------------------------


On Nov. 2, 2015, 8:31 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125924/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2015, 8:31 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> -------
> 
> To that end, this patch unifies both duplicated codes so it keeps consistent.
> 
> 
> Diffs
> -----
> 
>   src/lib/jobs/kjob.h cfb6909 
>   src/lib/jobs/kjob.cpp ff5a171 
> 
> Diff: https://git.reviewboard.kde.org/r/125924/diff/
> 
> 
> Testing
> -------
> 
> Tests still pass, addresses issue in KIO: https://git.reviewboard.kde.org/r/125164/
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151103/8007072b/attachment.html>