Review Request 125924: KJob::kill(Quiet) should also exit the event loop

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125924/#review87922
-----------------------------------------------------------

Ship it!


lgtm, esp. if the tests pass


src/lib/jobs/kjob.h (line 644)
<https://git.reviewboard.kde.org/r/125924/#comment60319>

    move this into KJobPrivate, no?


- Milian Wolff


On Nov. 2, 2015, 7:31 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125924/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2015, 7:31 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> -------
> 
> To that end, this patch unifies both duplicated codes so it keeps consistent.
> 
> 
> Diffs
> -----
> 
>   src/lib/jobs/kjob.h cfb6909 
>   src/lib/jobs/kjob.cpp ff5a171 
> 
> Diff: https://git.reviewboard.kde.org/r/125924/diff/
> 
> 
> Testing
> -------
> 
> Tests still pass, addresses issue in KIO: https://git.reviewboard.kde.org/r/125164/
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151103/d79a2588/attachment.html>